archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix an issue with comment group aggregation.

Browse Source 
Summary:

Test Plan:

Reviewers:

CC:
This commit is contained in:
epriestley
2011-02-09 14:28:16 -08:00
parent 1636e8274a
commit 076f342aed
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php
View File

@@ -78,23 +78,16 @@ class ManiphestTransactionDetailView extends AphrontView {
require_celerity_resource('maniphest-transaction-detail-css');
$comment_transaction = null;
foreach ($this->transactions as $transaction) {
if ($transaction->hasComments()) {
$comment_transaction = $transaction;
break;
}
}
$any_transaction = reset($transactions);
$author = $this->handles[$transaction->getAuthorPHID()];
$comments = $transaction->getCache();
if (!strlen($comments)) {
$comments = $transaction->getComments();
if (strlen($comments)) {
$comments = $this->markupEngine->markupText($comments);
$transaction->setCache($comments);
$transaction->save();
}
}
$author = $this->handles[$any_transaction->getAuthorPHID()];
$more_classes = array();
$descs = array();
@@ -107,7 +100,14 @@ class ManiphestTransactionDetailView extends AphrontView {
$more_classes = implode(' ', $classes);
if ($transaction->hasComments()) {
if ($comment_transaction && $comment_transaction->hasComments()) {
$comments = $comment_transaction->getCache();
if (!strlen($comments)) {
$comments = $comment_transaction->getComments();
$comments = $this->markupEngine->markupText($comments);
$transaction->setCache($comments);
$transaction->save();
}
$comment_block =
'<div class="maniphest-transaction-comments phabricator-remarkup">'.
$comments.