archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Move generateDiffusionURI() into PhabricatorRepository

Browse Source 
Summary: Ref T4245. This further reduces the reliance on callsigns in Diffusion.

Test Plan:
  - Pretty reasonable test coverage already exists.
  - Browsed repository list, browse view, history view, content view, change view, commit view, tag view, branch view of repositories.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D14937
This commit is contained in:
epriestley
2016-01-04 08:00:13 -08:00
parent 08de131da5
commit 07e2596aa1
6 changed files with 155 additions and 196 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/applications/diffusion/controller/DiffusionExternalController.php
View File

@@ -45,13 +45,13 @@ final class DiffusionExternalController extends DiffusionController {
if ($best_match) {
$repository = $repositories[$best_match];
$redirect = DiffusionRequest::generateDiffusionURI(
$redirect = $repository->generateURI(
array(
'action' => 'browse',
'repository' => $repository,
'branch' => $repository->getDefaultBranch(),
'commit' => $id,
'action' => 'browse',
'branch' => $repository->getDefaultBranch(),
'commit' => $id,
));
return id(new AphrontRedirectResponse())->setURI($redirect);
}
}
@@ -83,10 +83,9 @@ final class DiffusionExternalController extends DiffusionController {
} else if (count($commits) == 1) {
$commit = head($commits);
$repo = $repositories[$commit->getRepositoryID()];
$redirect = DiffusionRequest::generateDiffusionURI(
$redirect = $repo->generateURI(
array(
'action' => 'browse',
'repository' => $repo,
'branch' => $repo->getDefaultBranch(),
'commit' => $commit->getCommitIdentifier(),
));
@@ -96,10 +95,9 @@ final class DiffusionExternalController extends DiffusionController {
$rows = array();
foreach ($commits as $commit) {
$repo = $repositories[$commit->getRepositoryID()];
$href = DiffusionRequest::generateDiffusionURI(
$href = $repo->generateURI(
array(
'action' => 'browse',
'repository' => $repo,
'branch' => $repo->getDefaultBranch(),
'commit' => $commit->getCommitIdentifier(),
));