Port MySQL settings to PHP
Summary: - Ports MySQL settings to PHP. - Removes "mysql.retries" -- this existed only because Magic Numbers Are Bad, but there is no concievable reason it should ever be set to anything other than 3. - Introduced "Hidden" config, which isn't visible from the web (for SaaS, we'll just mark anything with secret keys as "hidden"). - Introduced "Masked" config, which will be masked in darkconsole once that gets updated. - "Hidden" implies "Masked" and "Locked". - Moved "storage.default-namespace" here -- it probably makes more sense than core; this was my bad in T2255. - Put cancel button back for hidden/locked config. - Introduce 'class' config type. Test Plan: Viewed MySQL options. None are editable. Reviewers: codeblock, btrahan Reviewed By: codeblock CC: aran Maniphest Tasks: T2255 Differential Revision: https://secure.phabricator.com/D4326
This commit is contained in:
@@ -67,22 +67,24 @@ final class PhabricatorConfigGroupController
|
||||
|
||||
$list = new PhabricatorObjectItemListView();
|
||||
foreach ($options as $option) {
|
||||
$current_value = PhabricatorEnv::getEnvConfig($option->getKey());
|
||||
$current_value = $this->prettyPrintJSON($current_value);
|
||||
$current_value = phutil_render_tag(
|
||||
'div',
|
||||
array(
|
||||
'class' => 'config-options-current-value',
|
||||
),
|
||||
'<span>'.pht('Current Value:').'</span> '.
|
||||
phutil_escape_html($current_value));
|
||||
|
||||
|
||||
$item = id(new PhabricatorObjectItemView())
|
||||
->setHeader($option->getKey())
|
||||
->setHref('/config/edit/'.$option->getKey().'/')
|
||||
->addAttribute(phutil_escape_html($option->getSummary()))
|
||||
->appendChild($current_value);
|
||||
->addAttribute(phutil_escape_html($option->getSummary()));
|
||||
|
||||
if (!$option->getHidden()) {
|
||||
$current_value = PhabricatorEnv::getEnvConfig($option->getKey());
|
||||
$current_value = $this->prettyPrintJSON($current_value);
|
||||
$current_value = phutil_render_tag(
|
||||
'div',
|
||||
array(
|
||||
'class' => 'config-options-current-value',
|
||||
),
|
||||
'<span>'.pht('Current Value:').'</span> '.
|
||||
phutil_escape_html($current_value));
|
||||
|
||||
$item->appendChild($current_value);
|
||||
}
|
||||
|
||||
$db_value = idx($db_values, $option->getKey());
|
||||
if ($db_value && !$db_value->getIsDeleted()) {
|
||||
@@ -91,7 +93,9 @@ final class PhabricatorConfigGroupController
|
||||
$item->addIcon('edit-grey', pht('Default'));
|
||||
}
|
||||
|
||||
if ($option->getLocked()) {
|
||||
if ($option->getHidden()) {
|
||||
$item->addIcon('unpublish', pht('Hidden'));
|
||||
} else if ($option->getLocked()) {
|
||||
$item->addIcon('lock', pht('Locked'));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user