archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Change double quotes to single quotes.

Browse Source 
Summary: Ran `arc lint --apply-patches --everything` over rP, mainly to change double quotes to single quotes where appropriate. These changes also validate that the `ArcanistXHPASTLinter::LINT_DOUBLE_QUOTE` rule is working as expected.

Test Plan: Eyeballed it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9431
This commit is contained in:
Joshua Spence
2014-06-09 11:36:49 -07:00
committed by epriestley
parent 78f783222e
commit 0a62f13464
560 changed files with 1721 additions and 1722 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/base/controller/PhabricatorController.php
View File

@@ -251,7 +251,7 @@ abstract class PhabricatorController extends AphrontController {
public function getApplicationURI($path = '') {
if (!$this->getCurrentApplication()) {
throw new Exception("No application!");
throw new Exception('No application!');
}
return $this->getCurrentApplication()->getApplicationURI($path);
}
@@ -324,7 +324,7 @@ abstract class PhabricatorController extends AphrontController {
if (isset($seen[$hash])) {
$seen[] = get_class($response);
throw new Exception(
"Cycle while reducing proxy responses: ".
'Cycle while reducing proxy responses: '.
implode(' -> ', $seen));
}
$seen[$hash] = get_class($response);

20
src/applications/base/controller/__tests__/PhabricatorAccessControlTestCase.php
View File

@@ -63,7 +63,7 @@ final class PhabricatorAccessControlTestCase
// Test standard defaults.
$this->checkAccess(
"Default",
'Default',
id(clone $controller),
$request,
array(
@@ -82,7 +82,7 @@ final class PhabricatorAccessControlTestCase
$env->overrideEnvConfig('auth.require-email-verification', true);
$this->checkAccess(
"Email Verification Required",
'Email Verification Required',
id(clone $controller),
$request,
array(
@@ -97,7 +97,7 @@ final class PhabricatorAccessControlTestCase
));
$this->checkAccess(
"Email Verification Required, With Exception",
'Email Verification Required, With Exception',
id(clone $controller)->setConfig('email', false),
$request,
array(
@@ -116,7 +116,7 @@ final class PhabricatorAccessControlTestCase
// Test admin access.
$this->checkAccess(
"Admin Required",
'Admin Required',
id(clone $controller)->setConfig('admin', true),
$request,
array(
@@ -134,7 +134,7 @@ final class PhabricatorAccessControlTestCase
// Test disabled access.
$this->checkAccess(
"Allow Disabled",
'Allow Disabled',
id(clone $controller)->setConfig('enabled', false),
$request,
array(
@@ -152,7 +152,7 @@ final class PhabricatorAccessControlTestCase
// Test no login required.
$this->checkAccess(
"No Login Required",
'No Login Required',
id(clone $controller)->setConfig('login', false),
$request,
array(
@@ -170,7 +170,7 @@ final class PhabricatorAccessControlTestCase
// Test public access.
$this->checkAccess(
"No Login Required",
'No Login Required',
id(clone $controller)->setConfig('public', true),
$request,
array(
@@ -185,7 +185,7 @@ final class PhabricatorAccessControlTestCase
$env->overrideEnvConfig('policy.allow-public', true);
$this->checkAccess(
"Public + configured",
'Public + configured',
id(clone $controller)->setConfig('public', true),
$request,
array(
@@ -210,7 +210,7 @@ final class PhabricatorAccessControlTestCase
$app_controller = id(clone $controller)->setCurrentApplication($app);
$this->checkAccess(
"Application Controller",
'Application Controller',
$app_controller,
$request,
array(
@@ -225,7 +225,7 @@ final class PhabricatorAccessControlTestCase
));
$this->checkAccess(
"Application Controller",
'Application Controller',
id(clone $app_controller)->setConfig('login', false),
$request,
array(