archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Add typehints to queryfx() et al.

Browse Source 
Test Plan: /D123

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D2203
This commit is contained in:
vrana
2012-04-11 07:04:35 -07:00
parent cd2bca664c
commit 0ad7a01b8d
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/storage/qsprintf/qsprintf.php
View File

@@ -72,7 +72,7 @@
* *
* @group storage * @group storage
*/ */
function qsprintf($conn, $pattern/*, ... */) { function qsprintf(AphrontDatabaseConnection $conn, $pattern/*, ... */) {
$args = func_get_args(); $args = func_get_args();
array_shift($args); array_shift($args);
return xsprintf('xsprintf_query', $conn, $args); return xsprintf('xsprintf_query', $conn, $args);
@@ -81,7 +81,7 @@ function qsprintf($conn, $pattern/*, ... */) {
/** /**
* @group storage * @group storage
*/ */
function vqsprintf($conn, $pattern, array $argv) { function vqsprintf(AphrontDatabaseConnection $conn, $pattern, array $argv) {
array_unshift($argv, $pattern); array_unshift($argv, $pattern);
return xsprintf('xsprintf_query', $conn, $argv); return xsprintf('xsprintf_query', $conn, $argv);
} }

10
src/storage/queryfx/queryfx.php
View File

@@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -28,7 +28,7 @@ function queryfx(AphrontDatabaseConnection $conn, $sql/*, ... */) {
/** /**
* @group storage * @group storage
*/ */
function vqueryfx($conn, $sql, $argv) { function vqueryfx(AphrontDatabaseConnection $conn, $sql, array $argv) {
array_unshift($argv, $conn, $sql); array_unshift($argv, $conn, $sql);
call_user_func_array('queryfx', $argv); call_user_func_array('queryfx', $argv);
} }
@@ -36,7 +36,7 @@ function vqueryfx($conn, $sql, $argv) {
/** /**
* @group storage * @group storage
*/ */
function queryfx_all($conn, $sql/*, ... */) { function queryfx_all(AphrontDatabaseConnection $conn, $sql/*, ... */) {
$argv = func_get_args(); $argv = func_get_args();
call_user_func_array('queryfx', $argv); call_user_func_array('queryfx', $argv);
return $conn->selectAllResults(); return $conn->selectAllResults();
@@ -45,7 +45,7 @@ function queryfx_all($conn, $sql/*, ... */) {
/** /**
* @group storage * @group storage
*/ */
function queryfx_one($conn, $sql/*, ... */) { function queryfx_one(AphrontDatabaseConnection $conn, $sql/*, ... */) {
$argv = func_get_args(); $argv = func_get_args();
$ret = call_user_func_array('queryfx_all', $argv); $ret = call_user_func_array('queryfx_all', $argv);
if (count($ret) > 1) { if (count($ret) > 1) {
@@ -60,7 +60,7 @@ function queryfx_one($conn, $sql/*, ... */) {
/** /**
* @group storage * @group storage
*/ */
function vqueryfx_all($conn, $sql, array $argv) { function vqueryfx_all(AphrontDatabaseConnection $conn, $sql, array $argv) {
array_unshift($argv, $conn, $sql); array_unshift($argv, $conn, $sql);
call_user_func_array('queryfx', $argv); call_user_func_array('queryfx', $argv);
return $conn->selectAllResults(); return $conn->selectAllResults();