archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Pholio CSS touchups for inline comments.

Browse Source 
Summary: Tightened up spaces, made inline area more 'inset', tweaked colors to match timeline view.

Test Plan: Tested mocks with and without inline comments.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5188
This commit is contained in:
Chad Little
2013-03-03 09:19:07 -08:00
parent 752055a45c
commit 0dde637059
4 changed files with 41 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/__celerity_resource_map__.php
View File

@@ -3218,7 +3218,7 @@ celerity_register_resource_map(array(
),
'pholio-css' =>
array(
'uri' => '/res/94883ddc/rsrc/css/application/pholio/pholio.css',
'uri' => '/res/08c8c85a/rsrc/css/application/pholio/pholio.css',
'type' => 'css',
'requires' =>
array(
@@ -3227,7 +3227,7 @@ celerity_register_resource_map(array(
),
'pholio-inline-comments-css' =>
array(
'uri' => '/res/2b32b3b6/rsrc/css/application/pholio/pholio-inline-comments.css',
'uri' => '/res/647d658d/rsrc/css/application/pholio/pholio-inline-comments.css',
'type' => 'css',
'requires' =>
array(

19
src/applications/pholio/view/PholioMockImagesView.php
View File

@@ -66,14 +66,7 @@ final class PholioMockImagesView extends AphrontView {
),
'');
$mockview[] = phutil_tag(
'div',
array(
'class' => 'pholio-mock-image-container',
'id' => 'pholio-mock-image-container'
),
array($mock_wrapper, $inline_comments_holder));
$carousel_holder = '';
if (count($mock->getImages()) > 0) {
$thumbnails = array();
foreach ($mock->getImages() as $image) {
@@ -105,7 +98,7 @@ final class PholioMockImagesView extends AphrontView {
$tag);
}
$mockview[] = phutil_tag(
$carousel_holder = phutil_tag(
'div',
array(
'id' => 'pholio-mock-carousel',
@@ -114,6 +107,14 @@ final class PholioMockImagesView extends AphrontView {
$thumbnails);
}
$mockview[] = phutil_tag(
'div',
array(
'class' => 'pholio-mock-image-container',
'id' => 'pholio-mock-image-container'
),
array($mock_wrapper, $carousel_holder, $inline_comments_holder));
return $this->renderSingleView($mockview);
}
}