Stop Phriction handling it's own Subscribers
Summary: Stop Phriction displaying subscribers twice. Test Plan: Add Subscriber, remove subscriber, make sure I see only one subscribers list. Fixes T3534 Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T3534 Differential Revision: https://secure.phabricator.com/D6457
This commit is contained in:
@@ -85,10 +85,8 @@ final class PhrictionDocumentController
|
||||
}
|
||||
$page_title = $content->getTitle();
|
||||
|
||||
$subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID(
|
||||
$document->getPHID());
|
||||
$properties = $this
|
||||
->buildPropertyListView($document, $content, $slug, $subscribers);
|
||||
->buildPropertyListView($document, $content, $slug);
|
||||
|
||||
$doc_status = $document->getStatus();
|
||||
$current_status = $content->getChangeType();
|
||||
@@ -201,8 +199,7 @@ final class PhrictionDocumentController
|
||||
private function buildPropertyListView(
|
||||
PhrictionDocument $document,
|
||||
PhrictionContent $content,
|
||||
$slug,
|
||||
array $subscribers) {
|
||||
$slug) {
|
||||
|
||||
$viewer = $this->getRequest()->getUser();
|
||||
$view = id(new PhabricatorPropertyListView())
|
||||
@@ -225,10 +222,6 @@ final class PhrictionDocumentController
|
||||
$project_phid,
|
||||
));
|
||||
|
||||
if ($subscribers) {
|
||||
$phids = array_merge($phids, $subscribers);
|
||||
}
|
||||
|
||||
$this->loadHandles($phids);
|
||||
|
||||
$project_info = null;
|
||||
@@ -253,11 +246,6 @@ final class PhrictionDocumentController
|
||||
}
|
||||
$view->addProperty(pht('Last Updated'), $when);
|
||||
|
||||
if ($subscribers) {
|
||||
$subscribers = $this->renderHandlesForPHIDs($subscribers, ',');
|
||||
$view->addProperty(pht('Subscribers'), $subscribers);
|
||||
}
|
||||
|
||||
return $view;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user