archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Move differential revision to its own table column in blame view

Browse Source 
Summary: There is still some layout issues with revisions, so I've tested it better and moved it to it's own column

Test Plan: Fake in some revision data, test various sizes and shapes.

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18473
This commit is contained in:
Chad Little
2017-08-24 19:36:33 -07:00
parent c49896f7c5
commit 12ae08b6b1
3 changed files with 23 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
resources/celerity/map.php
View File

@@ -74,7 +74,7 @@ return array(
'rsrc/css/application/diffusion/diffusion-icons.css' => '0c15255e', 'rsrc/css/application/diffusion/diffusion-icons.css' => '0c15255e',
'rsrc/css/application/diffusion/diffusion-readme.css' => '419dd5b6', 'rsrc/css/application/diffusion/diffusion-readme.css' => '419dd5b6',
'rsrc/css/application/diffusion/diffusion-repository.css' => 'ee6f20ec', 'rsrc/css/application/diffusion/diffusion-repository.css' => 'ee6f20ec',
'rsrc/css/application/diffusion/diffusion-source.css' => '5c697665', 'rsrc/css/application/diffusion/diffusion-source.css' => 'cb2bf02e',
'rsrc/css/application/diffusion/diffusion.css' => 'ceacf994', 'rsrc/css/application/diffusion/diffusion.css' => 'ceacf994',
'rsrc/css/application/feed/feed.css' => 'ecd4ec57', 'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
'rsrc/css/application/files/global-drag-and-drop.css' => 'b556a948', 'rsrc/css/application/files/global-drag-and-drop.css' => 'b556a948',
@@ -574,7 +574,7 @@ return array(
'diffusion-icons-css' => '0c15255e', 'diffusion-icons-css' => '0c15255e',
'diffusion-readme-css' => '419dd5b6', 'diffusion-readme-css' => '419dd5b6',
'diffusion-repository-css' => 'ee6f20ec', 'diffusion-repository-css' => 'ee6f20ec',
'diffusion-source-css' => '5c697665', 'diffusion-source-css' => 'cb2bf02e',
'diviner-shared-css' => '896f1d43', 'diviner-shared-css' => '896f1d43',
'font-fontawesome' => 'e838e088', 'font-fontawesome' => 'e838e088',
'font-lato' => 'c7ccd872', 'font-lato' => 'c7ccd872',

19
src/applications/diffusion/controller/DiffusionBrowseController.php
View File

@@ -706,6 +706,7 @@ final class DiffusionBrowseController extends DiffusionController {
$buttons[] = $buttons[] =
id(new PHUIButtonView()) id(new PHUIButtonView())
->setTag('a')
->setText(pht('Last Change')) ->setText(pht('Last Change'))
->setColor(PHUIButtonView::GREY) ->setColor(PHUIButtonView::GREY)
->setHref( ->setHref(
@@ -1175,19 +1176,21 @@ final class DiffusionBrowseController extends DiffusionController {
), ),
$before_link); $before_link);
$object_links = array();
$object_links[] = $commit_link;
if ($revision_link) {
$object_links[] = phutil_tag('span', array(), '/');
$object_links[] = $revision_link;
}
$row[] = phutil_tag( $row[] = phutil_tag(
'th', 'th',
array( array(
'class' => 'diffusion-rev-link', 'class' => 'diffusion-rev-link',
), ),
$object_links); $commit_link);
if ($revision_link) {
$row[] = phutil_tag(
'th',
array(
'class' => 'diffusion-blame-revision',
),
$revision_link);
}
$row[] = phutil_tag( $row[] = phutil_tag(
'th', 'th',

18
webroot/rsrc/css/application/diffusion/diffusion-source.css
View File

@@ -40,11 +40,12 @@
.diffusion-blame-date { .diffusion-blame-date {
background: {$lightgreybackground}; background: {$lightgreybackground};
font: {$basefont}; font: {$basefont};
font-size: {$smallestfontsize}; font-size: {$smallerfontsize};
} }
.diffusion-blame-link, .diffusion-blame-link,
.diffusion-line-link { .diffusion-line-link,
.diffusion-blame-revision {
background: {$lightgreybackground}; background: {$lightgreybackground};
} }
@@ -53,7 +54,7 @@
min-width: 130px; min-width: 130px;
background: {$lightgreybackground}; background: {$lightgreybackground};
font: {$basefont}; font: {$basefont};
font-size: {$smallestfontsize}; font-size: {$smallerfontsize};
} }
.diffusion-source a { .diffusion-source a {
@@ -61,17 +62,18 @@
} }
.diffusion-rev-link a { .diffusion-rev-link a {
max-width: 340px; max-width: 300px;
overflow: hidden; overflow: hidden;
white-space: nowrap; white-space: nowrap;
text-overflow: ellipsis; text-overflow: ellipsis;
margin: 3px 8px;
display: block;
} }
.diffusion-rev-link a, .diffusion-blame-date a,
.diffusion-rev-link span, .diffusion-blame-revision a {
.diffusion-blame-date a { float: right;
margin: 3px 8px; margin: 3px 8px;
float: left;
} }
.diffusion-rev-link span { .diffusion-rev-link span {