archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

[Redesign] Center Pinboard Items

Browse Source 
Summary: Ref T8099, This centers, but floats, all pinboards items based on screen width.

Test Plan:
Test desktop, mobile break points. Items scale nicely.

{F459680}

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13085
This commit is contained in:
Chad Little
2015-05-31 14:28:16 -07:00
parent f5a7e8bdbd
commit 140f63e398
4 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
resources/celerity/map.php
View File

@@ -142,7 +142,7 @@ return array(
'rsrc/css/phui/phui-list.css' => 'e448b6ba', 'rsrc/css/phui/phui-list.css' => 'e448b6ba',
'rsrc/css/phui/phui-object-box.css' => 'c57e6647', 'rsrc/css/phui/phui-object-box.css' => 'c57e6647',
'rsrc/css/phui/phui-object-item-list-view.css' => '29ded459', 'rsrc/css/phui/phui-object-item-list-view.css' => '29ded459',
'rsrc/css/phui/phui-pinboard-view.css' => '55b27bc3', 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb', 'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb',
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b', 'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
'rsrc/css/phui/phui-spacing.css' => '042804d6', 'rsrc/css/phui/phui-spacing.css' => '042804d6',
@@ -778,7 +778,7 @@ return array(
'phui-list-view-css' => 'e448b6ba', 'phui-list-view-css' => 'e448b6ba',
'phui-object-box-css' => 'c57e6647', 'phui-object-box-css' => 'c57e6647',
'phui-object-item-list-view-css' => '29ded459', 'phui-object-item-list-view-css' => '29ded459',
'phui-pinboard-view-css' => '55b27bc3', 'phui-pinboard-view-css' => '2495140e',
'phui-property-list-view-css' => '1baf23eb', 'phui-property-list-view-css' => '1baf23eb',
'phui-remarkup-preview-css' => '19ad512b', 'phui-remarkup-preview-css' => '19ad512b',
'phui-spacing-css' => '042804d6', 'phui-spacing-css' => '042804d6',

9
src/view/phui/PHUIPinboardItemView.php
View File

@@ -115,7 +115,7 @@ final class PHUIPinboardItemView extends AphrontView {
$classes[] = 'phui-pinboard-item-disabled'; $classes[] = 'phui-pinboard-item-disabled';
} }
return phutil_tag( $item = phutil_tag(
'div', 'div',
array( array(
'class' => implode(' ', $classes), 'class' => implode(' ', $classes),
@@ -126,6 +126,13 @@ final class PHUIPinboardItemView extends AphrontView {
$content, $content,
$icons, $icons,
)); ));
return phutil_tag(
'li',
array(
'class' => 'phui-pinboard-list-item',
),
$item);
} }
} }

2
src/view/phui/PHUIPinboardView.php
View File

@@ -27,7 +27,7 @@ final class PHUIPinboardView extends AphrontView {
} }
return phutil_tag( return phutil_tag(
'div', 'ul',
array( array(
'class' => 'phui-pinboard-view', 'class' => 'phui-pinboard-view',
), ),

13
webroot/rsrc/css/phui/phui-pinboard-view.css
View File

@@ -3,16 +3,13 @@
*/ */
.phui-pinboard-view { .phui-pinboard-view {
padding: 8px 0 16px 16px;
overflow: hidden;
}
.dashboard-pane .phui-pinboard-view {
padding: 16px 8px; padding: 16px 8px;
overflow: hidden;
text-align: center;
} }
.device-phone .phui-pinboard-view { .phui-pinboard-list-item {
padding: 0; display: inline;
} }
.phui-pinboard-item-view { .phui-pinboard-item-view {
@@ -25,7 +22,7 @@
} }
.phui-pinboard-view .phui-pinboard-item-view { .phui-pinboard-view .phui-pinboard-item-view {
float: left; display: inline-block;
} }
.device-desktop .phui-pinboard-item-view:hover { .device-desktop .phui-pinboard-item-view:hover {