Mark fields as required on MenuItems

Summary: Mark required fields as required. Though in testing, none of these work.

Test Plan: Try to save a form without an app/project/dashboard and see success (not expected)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17231

src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php

@@ -34,6 +34,7 @@ final class PhabricatorApplicationProfileMenuItem
       id(new PhabricatorDatasourceEditField())
         ->setKey('application')
         ->setLabel(pht('Application'))
+        ->setIsRequired(true)
         ->setDatasource(new PhabricatorApplicationDatasource())
         ->setSingleValue($config->getMenuItemProperty('application')),
     );

src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php

@@ -77,6 +77,7 @@ final class PhabricatorDashboardProfileMenuItem
       id(new PhabricatorDatasourceEditField())
         ->setKey('dashboardPHID')
         ->setLabel(pht('Dashboard'))
+        ->setIsRequired(true)
         ->setDatasource(new PhabricatorDashboardDatasource())
         ->setSingleValue($config->getMenuItemProperty('dashboardPHID')),
     );

src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php

@@ -85,6 +85,7 @@ final class PhabricatorEditEngineProfileMenuItem
       id(new PhabricatorDatasourceEditField())
         ->setKey('formKey')
         ->setLabel(pht('Form'))
+        ->setIsRequired(true)
         ->setDatasource(new PhabricatorEditEngineDatasource())
         ->setSingleValue($config->getMenuItemProperty('formKey')),
     );

src/applications/search/menuitem/PhabricatorProjectProfileMenuItem.php

@@ -78,6 +78,7 @@ final class PhabricatorProjectProfileMenuItem
       id(new PhabricatorDatasourceEditField())
         ->setKey('project')
         ->setLabel(pht('Project'))
+        ->setIsRequired(true)
         ->setDatasource(new PhabricatorProjectDatasource())
         ->setSingleValue($config->getMenuItemProperty('project')),
     );