archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

[Redesign] Clean up <select>

Browse Source 
Summary: Ref T8099, Ref T8449. Adds a min width to selects (can't think of anything this breaks in ui) and adds space around space select.

Test Plan: Review a number of selects in different UIs, forms, dialogs.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099, T8449

Differential Revision: https://secure.phabricator.com/D13523
This commit is contained in:
Chad Little
2015-07-02 14:25:45 -07:00
parent 01a1a87879
commit 18e1bd2e45
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
resources/celerity/map.php
View File

@@ -7,7 +7,7 @@
*/ */
return array( return array(
'names' => array( 'names' => array(
'core.pkg.css' => 'a7580731', 'core.pkg.css' => '7f52c50a',
'core.pkg.js' => 'a590b451', 'core.pkg.js' => 'a590b451',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '73f1d1bc', 'differential.pkg.css' => '73f1d1bc',
@@ -133,7 +133,7 @@ return array(
'rsrc/css/phui/phui-feed-story.css' => 'c7d8113a', 'rsrc/css/phui/phui-feed-story.css' => 'c7d8113a',
'rsrc/css/phui/phui-fontkit.css' => 'cb8ae7ad', 'rsrc/css/phui/phui-fontkit.css' => 'cb8ae7ad',
'rsrc/css/phui/phui-form-view.css' => '621b21c5', 'rsrc/css/phui/phui-form-view.css' => '621b21c5',
'rsrc/css/phui/phui-form.css' => '17ce37a9', 'rsrc/css/phui/phui-form.css' => 'afdb2c6e',
'rsrc/css/phui/phui-header-view.css' => '4d09d68f', 'rsrc/css/phui/phui-header-view.css' => '4d09d68f',
'rsrc/css/phui/phui-icon.css' => '88ba9081', 'rsrc/css/phui/phui-icon.css' => '88ba9081',
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8', 'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
@@ -775,7 +775,7 @@ return array(
'phui-feed-story-css' => 'c7d8113a', 'phui-feed-story-css' => 'c7d8113a',
'phui-font-icon-base-css' => '3dad2ae3', 'phui-font-icon-base-css' => '3dad2ae3',
'phui-fontkit-css' => 'cb8ae7ad', 'phui-fontkit-css' => 'cb8ae7ad',
'phui-form-css' => '17ce37a9', 'phui-form-css' => 'afdb2c6e',
'phui-form-view-css' => '621b21c5', 'phui-form-view-css' => '621b21c5',
'phui-header-view-css' => '4d09d68f', 'phui-header-view-css' => '4d09d68f',
'phui-icon-view-css' => '88ba9081', 'phui-icon-view-css' => '88ba9081',

1
src/view/form/control/AphrontFormPolicyControl.php
View File

@@ -351,6 +351,7 @@ final class AphrontFormPolicyControl extends AphrontFormControl {
$space_phid), $space_phid),
array( array(
'name' => 'spacePHID', 'name' => 'spacePHID',
'class' => 'aphront-space-select-control-knob',
)); ));
return $select; return $select;

11
webroot/rsrc/css/phui/phui-form.css
View File

@@ -107,8 +107,9 @@ input[type="checkbox"] {
select { select {
height: 24px; height: 24px;
line-height: 24px; line-height: 24px;
border: 1px solid #a1a5a9; border: 1px solid {$lightgreyborder};
background-color: #ffffff; background-color: #ffffff;
min-width: 140px;
} }
select[multiple], select[multiple],
@@ -144,3 +145,11 @@ select[disabled],
input[disabled] { input[disabled] {
opacity: 0.5; opacity: 0.5;
} }
.aphront-space-select-control-knob {
margin: 2px 8px 2px 0;
}
.device .aphront-space-select-control-knob {
margin-bottom: 8px;
}