Move project icon editing into "Edit Details"

Summary: Ref T5482. Instead of editing icons and details seaparetly, use a bunch of Javascript to pop a dialog instead.

Test Plan: {F170528}

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5482

Differential Revision: https://secure.phabricator.com/D9743

src/applications/project/controller/PhabricatorProjectEditMainController.php

@@ -93,14 +93,6 @@ final class PhabricatorProjectEditMainController
         ->setDisabled(!$can_edit)
         ->setWorkflow(!$can_edit));
 
-    $view->addAction(
-      id(new PhabricatorActionView())
-        ->setName(pht('Edit Icon'))
-        ->setIcon($project->getIcon())
-        ->setHref($this->getApplicationURI("icon/{$id}/"))
-        ->setDisabled(!$can_edit)
-        ->setWorkflow(true));
-
     $view->addAction(
       id(new PhabricatorActionView())
         ->setName(pht('Edit Picture'))