Remove some low-hanging buildStandardPageResponse() methods
Summary: Ref T9690. I wanted to do an example of how to do these but it looks like most of them are trivial (no callsites) and the rest are a little tricky (weird interaction with frames, or in Releeph). Test Plan: - Used `grep` to look for callsites. - Hit all applications locally, everything worked. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9690 Differential Revision: https://secure.phabricator.com/D14385
This commit is contained in:
@@ -2,18 +2,6 @@
|
||||
|
||||
abstract class PhabricatorAuthController extends PhabricatorController {
|
||||
|
||||
public function buildStandardPageResponse($view, array $data) {
|
||||
$page = $this->buildStandardPageView();
|
||||
|
||||
$page->setApplicationName(pht('Login'));
|
||||
$page->setBaseURI('/login/');
|
||||
$page->setTitle(idx($data, 'title'));
|
||||
$page->appendChild($view);
|
||||
|
||||
$response = new AphrontWebpageResponse();
|
||||
return $response->setContent($page->render());
|
||||
}
|
||||
|
||||
protected function renderErrorPage($title, array $messages) {
|
||||
$view = new PHUIInfoView();
|
||||
$view->setTitle($title);
|
||||
|
||||
Reference in New Issue
Block a user