archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Unmuck some issues with viewing HEAD changes.

Browse Source
This commit is contained in:
epriestley
2011-04-02 17:11:51 -07:00
parent 8f5d01d451
commit 1b2140d7a4
6 changed files with 49 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/applications/diffusion/query/diff/git/DiffusionGitDiffQuery.php
View File

@@ -22,6 +22,17 @@ final class DiffusionGitDiffQuery extends DiffusionDiffQuery {
$drequest = $this->getRequest();
$repository = $drequest->getRepository();
if (!$drequest->getRawCommit()) {
$effective_commit = $this->getEffectiveCommit();
if (!$effective_commit) {
return null;
}
// TODO: This side effect is kind of skethcy.
$drequest->setCommit($effective_commit);
} else {
$effective_commit = $drequest->getCommit();
}
$options = array(
'-M',
'-C',
@@ -36,8 +47,8 @@ final class DiffusionGitDiffQuery extends DiffusionDiffQuery {
list($raw_diff) = execx(
"(cd %s && git diff {$options} %s^ %s -- %s)",
$repository->getDetail('local-path'),
$drequest->getCommit(),
$drequest->getCommit(),
$effective_commit,
$effective_commit,
$drequest->getPath());
$parser = new ArcanistDiffParser();