Add owner to task boards, tidy UI
Summary: Displays task owner, hides grip texture. Test Plan: Visit a board in my sandbox, grab and move things. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8246
This commit is contained in:
@@ -4,6 +4,7 @@ final class PhabricatorProjectBoardController
|
||||
extends PhabricatorProjectController {
|
||||
|
||||
private $id;
|
||||
private $handles;
|
||||
|
||||
public function shouldAllowPublic() {
|
||||
return true;
|
||||
@@ -90,6 +91,8 @@ final class PhabricatorProjectBoardController
|
||||
'moveURI' => $this->getApplicationURI('move/'.$project->getID().'/'),
|
||||
));
|
||||
|
||||
$this->handles = ManiphestTaskListView::loadTaskHandles($viewer, $tasks);
|
||||
|
||||
foreach ($columns as $column) {
|
||||
$panel = id(new PHUIWorkpanelView())
|
||||
->setHeader($column->getDisplayName())
|
||||
@@ -181,6 +184,7 @@ final class PhabricatorProjectBoardController
|
||||
private function renderTaskCard(ManiphestTask $task) {
|
||||
$request = $this->getRequest();
|
||||
$viewer = $request->getUser();
|
||||
$handles = $this->handles;
|
||||
|
||||
$color_map = ManiphestTaskPriority::getColorMap();
|
||||
$bar_color = idx($color_map, $task->getPriority(), 'grey');
|
||||
@@ -191,23 +195,30 @@ final class PhabricatorProjectBoardController
|
||||
$task,
|
||||
PhabricatorPolicyCapability::CAN_EDIT);
|
||||
|
||||
return id(new PHUIObjectItemView())
|
||||
->setObjectName('T'.$task->getID())
|
||||
->setHeader($task->getTitle())
|
||||
->setGrippable($can_edit)
|
||||
->setHref('/T'.$task->getID())
|
||||
->addSigil('project-card')
|
||||
->setMetadata(
|
||||
array(
|
||||
'objectPHID' => $task->getPHID(),
|
||||
))
|
||||
->addAction(
|
||||
id(new PHUIListItemView())
|
||||
->setName(pht('Edit'))
|
||||
->setIcon('edit')
|
||||
->setHref('/maniphest/task/edit/'.$task->getID().'/')
|
||||
->setWorkflow(true))
|
||||
->setBarColor($bar_color);
|
||||
$card = id(new PHUIObjectItemView())
|
||||
->setObjectName('T'.$task->getID())
|
||||
->setHeader($task->getTitle())
|
||||
->setGrippable($can_edit)
|
||||
->setHref('/T'.$task->getID())
|
||||
->addSigil('project-card')
|
||||
->setMetadata(
|
||||
array(
|
||||
'objectPHID' => $task->getPHID(),
|
||||
))
|
||||
->addAction(
|
||||
id(new PHUIListItemView())
|
||||
->setName(pht('Edit'))
|
||||
->setIcon('edit')
|
||||
->setHref('/maniphest/task/edit/'.$task->getID().'/')
|
||||
->setWorkflow(true))
|
||||
->setBarColor($bar_color);
|
||||
|
||||
if ($task->getOwnerPHID()) {
|
||||
$owner = $handles[$task->getOwnerPHID()];
|
||||
$card->addAttribute($owner->renderLink());
|
||||
}
|
||||
|
||||
return $card;
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user