Minor improvements to Applications application
Summary: I missed these in review, but here are a couple of tweaks: - Call `setWorkflow(true)` on the actions. This makes the dialogs pop up on the same page with Javascript if it's available. - When the user installs/uninstalls an application, send them back to the application's detail page, not the application list. Test Plan: - Uninstalled an application (saw dialog, got sent back to detail page). - Installed an application (saw dialog, got sent back to detail page). - Canceled an application uninstall. Reviewers: Afaque_Hussain Reviewed By: Afaque_Hussain CC: aran Differential Revision: https://secure.phabricator.com/D4762
This commit is contained in:
@@ -90,6 +90,7 @@ final class PhabricatorApplicationDetailViewController
|
||||
id(new PhabricatorActionView())
|
||||
->setName(pht('Uninstall'))
|
||||
->setIcon('delete')
|
||||
->setWorkflow(true)
|
||||
->setHref(
|
||||
$this->getApplicationURI(get_class($selected).'/uninstall/'))
|
||||
);
|
||||
@@ -98,6 +99,7 @@ final class PhabricatorApplicationDetailViewController
|
||||
id(new PhabricatorActionView())
|
||||
->setName(pht('Install'))
|
||||
->setIcon('new')
|
||||
->setWorkflow(true)
|
||||
->setHref(
|
||||
$this->getApplicationURI(get_class($selected).'/install/'))
|
||||
);
|
||||
@@ -107,6 +109,7 @@ final class PhabricatorApplicationDetailViewController
|
||||
id(new PhabricatorActionView())
|
||||
->setName(pht('Uninstall'))
|
||||
->setIcon('delete')
|
||||
->setWorkflow(true)
|
||||
->setDisabled(true)
|
||||
->setHref(
|
||||
$this->getApplicationURI(get_class($selected).'/uninstall/'))
|
||||
|
||||
Reference in New Issue
Block a user