Minor improvements to Applications application
Summary: I missed these in review, but here are a couple of tweaks: - Call `setWorkflow(true)` on the actions. This makes the dialogs pop up on the same page with Javascript if it's available. - When the user installs/uninstalls an application, send them back to the application's detail page, not the application list. Test Plan: - Uninstalled an application (saw dialog, got sent back to detail page). - Installed an application (saw dialog, got sent back to detail page). - Canceled an application uninstall. Reviewers: Afaque_Hussain Reviewed By: Afaque_Hussain CC: aran Differential Revision: https://secure.phabricator.com/D4762
This commit is contained in:
@@ -21,14 +21,16 @@ final class PhabricatorApplicationUninstallController
|
||||
return new Aphront404Response();
|
||||
}
|
||||
|
||||
$view_uri = $this->getApplicationURI('view/'.$this->application);
|
||||
|
||||
if ($request->isDialogFormPost()) {
|
||||
$this->manageApplication();
|
||||
return id(new AphrontRedirectResponse())->setURI('/applications/');
|
||||
return id(new AphrontRedirectResponse())->setURI($view_uri);
|
||||
}
|
||||
|
||||
$dialog = id(new AphrontDialogView())
|
||||
->setUser($user)
|
||||
->addCancelButton('/applications/view/'.$this->application);
|
||||
->addCancelButton($view_uri);
|
||||
|
||||
if ($this->action == 'install') {
|
||||
if ($selected->canUninstall()) {
|
||||
|
||||
Reference in New Issue
Block a user