Move "Send Welcome Email" to profiles and nuke old weird edit UI

Summary: Ref T4065. Moves the last of the weird alternate edit UI to profiles. The old "Edit" controller is now for creation only, and the funky pencil icon is gone.

Test Plan: Created accounts; sent welcome email.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4065

Differential Revision: https://secure.phabricator.com/D8670

src/applications/people/controller/PhabricatorPeopleRenameController.php

@@ -21,7 +21,7 @@ final class PhabricatorPeopleRenameController
       return new Aphront404Response();
     }
 
-    $profile_uri = '/p/'.$user->getUsername();
+    $profile_uri = '/p/'.$user->getUsername().'/';
 
     $errors = array();
 
@@ -75,8 +75,12 @@ final class PhabricatorPeopleRenameController
     $inst4 = pht(
       'Users who rely on password authentication will need to reset their '.
       'password after their username is changed (their username is part of '.
-      'the salt in the password hash). They will receive an email with '.
-      'instructions on how to do this.');
+      'the salt in the password hash).');
+
+    $inst5 = pht(
+      'The user will receive an email notifying them that you changed their '.
+      'username, with instructions for logging in and resetting their '.
+      'password if necessary.');
 
     $form = id(new AphrontFormView())
       ->setUser($admin)
@@ -103,6 +107,7 @@ final class PhabricatorPeopleRenameController
       ->appendParagraph($inst2)
       ->appendParagraph($inst3)
       ->appendParagraph($inst4)
+      ->appendParagraph($inst5)
       ->appendParagraph(null)
       ->appendChild($form->buildLayoutView())
       ->addSubmitButton(pht('Rename User'))