archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Allow custom actions in Differential to explicitly override "accept" stickiness

Browse Source 
Summary:
See PHI431. Ref T13102. An install is interested in a custom "non-sticky" accept action, roughly.

On the one hand, this is a pretty hacky patch. However, I suspect it inches us closer to T731, and I'm generally comfortable with exploring the realms of "Accept Next Update", "Unblock Without Accepting", etc., as long as most of it doesn't end up enabled by default in the upstream.

Test Plan:
  - Accepted and updated revisions normally, saw accepts respect global stickiness.
  - Modified the "Accept" action to explicitly be unsticky, saw nonsticky accept behavior after update.

Maniphest Tasks: T13102

Differential Revision: https://secure.phabricator.com/D19211
This commit is contained in:
epriestley
2018-03-12 16:39:29 -07:00
parent df8d4dff67
commit 1e93b49b1b
6 changed files with 78 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
resources/sql/autopatches/20180312.reviewers.01.options.sql Normal file
View File

@@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_differential.differential_reviewer
ADD options LONGTEXT NOT NULL COLLATE {$COLLATE_TEXT};

2
resources/sql/autopatches/20180312.reviewers.02.optionsdefault.sql Normal file
View File

@@ -0,0 +1,2 @@
UPDATE {$NAMESPACE}_differential.differential_reviewer
SET options = '{}' WHERE options = '';