Show coverage information in Differential
Summary: Render coverage information in the right gutter, if available. We could render some kind of summary report deal too but this seems like a good start. Test Plan: - Looked at diffs with coverage. - Looked at diffs without coverage. - Used inline comments, diff-of-diff, "show more", "show entire file", "show generated file", "undo". Nothing seemed disrupted by the addition of a 5th column. Reviewers: btrahan, tuomaspelkonen, jungejason Reviewed By: btrahan CC: zeeg, aran, epriestley Maniphest Tasks: T140 Differential Revision: https://secure.phabricator.com/D1527
This commit is contained in:
@@ -125,11 +125,37 @@ class DifferentialChangesetViewController extends DifferentialController {
|
||||
$changeset = $choice;
|
||||
}
|
||||
|
||||
$coverage = null;
|
||||
if ($right->getDiffID()) {
|
||||
$unit = id(new DifferentialDiffProperty())->loadOneWhere(
|
||||
'diffID = %d AND name = %s',
|
||||
$right->getDiffID(),
|
||||
'arc:unit');
|
||||
|
||||
if ($unit) {
|
||||
$coverage = array();
|
||||
foreach ($unit->getData() as $result) {
|
||||
$result_coverage = idx($result, 'coverage');
|
||||
if (!$result_coverage) {
|
||||
continue;
|
||||
}
|
||||
$file_coverage = idx($result_coverage, $right->getFileName());
|
||||
if (!$file_coverage) {
|
||||
continue;
|
||||
}
|
||||
$coverage[] = $file_coverage;
|
||||
}
|
||||
|
||||
$coverage = ArcanistUnitTestResult::mergeCoverage($coverage);
|
||||
}
|
||||
}
|
||||
|
||||
$spec = $request->getStr('range');
|
||||
list($range_s, $range_e, $mask) =
|
||||
DifferentialChangesetParser::parseRangeSpecification($spec);
|
||||
|
||||
$parser = new DifferentialChangesetParser();
|
||||
$parser->setCoverage($coverage);
|
||||
$parser->setChangeset($changeset);
|
||||
$parser->setRenderingReference($rendering_reference);
|
||||
$parser->setRenderCacheKey($render_cache_key);
|
||||
|
||||
Reference in New Issue
Block a user