archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Move DifferentialRevision to application PHIDs

Browse Source 
Summary: Ref T2715.

Test Plan: Used `phid.lookup` and `phid.query` to load handles. Grepped for `PHID_TYPE_DREV`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2715

Differential Revision: https://secure.phabricator.com/D6509
This commit is contained in:
epriestley
2013-07-21 08:11:37 -07:00
parent 5ca419174a
commit 1fb39a20d3
18 changed files with 104 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/search/controller/PhabricatorSearchAttachController.php
View File

@@ -198,7 +198,7 @@ final class PhabricatorSearchAttachController
private function getStrings() {
switch ($this->type) {
case PhabricatorPHIDConstants::PHID_TYPE_DREV:
case DifferentialPHIDTypeRevision::TYPECONST:
$noun = 'Revisions';
$selected = 'created';
break;
@@ -271,7 +271,7 @@ final class PhabricatorSearchAttachController
private function getEdgeType($src_type, $dst_type) {
$t_cmit = PhabricatorPHIDConstants::PHID_TYPE_CMIT;
$t_task = PhabricatorPHIDConstants::PHID_TYPE_TASK;
$t_drev = PhabricatorPHIDConstants::PHID_TYPE_DREV;
$t_drev = DifferentialPHIDTypeRevision::TYPECONST;
$t_mock = PhabricatorPHIDConstants::PHID_TYPE_MOCK;
$map = array(

2
src/applications/search/controller/PhabricatorSearchController.php
View File

@@ -47,7 +47,7 @@ final class PhabricatorSearchController
$query->setParameter('open', 1);
$query->setParameter(
'type',
PhabricatorPHIDConstants::PHID_TYPE_DREV);
DifferentialPHIDTypeRevision::TYPECONST);
break;
case PhabricatorSearchScope::SCOPE_OPEN_TASKS:
$query->setParameter('open', 1);

4
src/applications/search/controller/PhabricatorSearchSelectController.php
View File

@@ -70,7 +70,7 @@ final class PhabricatorSearchSelectController
case PhabricatorPHIDConstants::PHID_TYPE_TASK:
$pattern = '/\bT(\d+)\b/i';
break;
case PhabricatorPHIDConstants::PHID_TYPE_DREV:
case DifferentialPHIDTypeRevision::TYPECONST:
$pattern = '/\bD(\d+)\b/i';
break;
case PhabricatorPHIDConstants::PHID_TYPE_MOCK:
@@ -94,7 +94,7 @@ final class PhabricatorSearchSelectController
}
switch ($this->type) {
case PhabricatorPHIDConstants::PHID_TYPE_DREV:
case DifferentialPHIDTypeRevision::TYPECONST:
$objects = id(new DifferentialRevision())->loadAllWhere(
'id IN (%Ld)',
$object_ids);

2
src/applications/search/index/PhabricatorSearchAbstractDocument.php
View File

@@ -15,7 +15,7 @@ final class PhabricatorSearchAbstractDocument {
public static function getSupportedTypes() {
return array(
PhabricatorPHIDConstants::PHID_TYPE_DREV => 'Differential Revisions',
DifferentialPHIDTypeRevision::TYPECONST => 'Differential Revisions',
PhabricatorPHIDConstants::PHID_TYPE_CMIT => 'Repository Commits',
PhabricatorPHIDConstants::PHID_TYPE_TASK => 'Maniphest Tasks',
PhabricatorPHIDConstants::PHID_TYPE_WIKI => 'Phriction Documents',