archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Move DifferentialRevision to application PHIDs

Browse Source 
Summary: Ref T2715.

Test Plan: Used `phid.lookup` and `phid.query` to load handles. Grepped for `PHID_TYPE_DREV`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2715

Differential Revision: https://secure.phabricator.com/D6509
This commit is contained in:
epriestley
2013-07-21 08:11:37 -07:00
parent 5ca419174a
commit 1fb39a20d3
18 changed files with 104 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/search/controller/PhabricatorSearchSelectController.php
View File

@@ -70,7 +70,7 @@ final class PhabricatorSearchSelectController
case PhabricatorPHIDConstants::PHID_TYPE_TASK:
$pattern = '/\bT(\d+)\b/i';
break;
case PhabricatorPHIDConstants::PHID_TYPE_DREV:
case DifferentialPHIDTypeRevision::TYPECONST:
$pattern = '/\bD(\d+)\b/i';
break;
case PhabricatorPHIDConstants::PHID_TYPE_MOCK:
@@ -94,7 +94,7 @@ final class PhabricatorSearchSelectController
}
switch ($this->type) {
case PhabricatorPHIDConstants::PHID_TYPE_DREV:
case DifferentialPHIDTypeRevision::TYPECONST:
$objects = id(new DifferentialRevision())->loadAllWhere(
'id IN (%Ld)',
$object_ids);