Update Phabricator header to use FontAwesome

Summary: Updates header to use font-icons instead of images.

Test Plan: Test desktop and mobile layouts, Chrome, FF, Safari, IE.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D10930

src/applications/auth/application/PhabricatorAuthApplication.php

@@ -48,7 +48,7 @@ final class PhabricatorAuthApplication extends PhabricatorApplication {
       $item = id(new PHUIListItemView())
         ->addClass('core-menu-item')
         ->setName(pht('Log Out'))
-        ->setIcon('logout-sm')
+        ->setIcon('fa-sign-out')
         ->setWorkflow(true)
         ->setHref('/logout/')
         ->setSelected(($controller instanceof PhabricatorLogoutController))
@@ -64,7 +64,7 @@ final class PhabricatorAuthApplication extends PhabricatorApplication {
           ->addClass('core-menu-item')
           ->setName(pht('Log In'))
           // TODO: Login icon?
-          ->setIcon('power')
+          ->setIcon('fa-sign-in')
           ->setHref('/auth/start/')
           ->setAural(pht('Log In'))
           ->setOrder(900);

src/applications/celerity/CeleritySpriteGenerator.php

@@ -29,61 +29,6 @@ final class CeleritySpriteGenerator {
         'y' => 31,
         'css' => '.phabricator-crumb-divider',
       ),
-      'search' => array(
-        'x' => 24,
-        'y' => 24,
-        'css' => '.menu-icon-search',
-      ),
-      'search_blue' => array(
-        'x' => 24,
-        'y' => 24,
-        'css' => '.menu-icon-search-blue',
-      ),
-      'new' => array(
-        'x' => 24,
-        'y' => 24,
-        'css' => '.menu-icon-new',
-      ),
-      'new_blue' => array(
-        'x' => 24,
-        'y' => 24,
-        'css' => '.menu-icon-new-blue',
-      ),
-      'info-sm' => array(
-        'x' => 28,
-        'y' => 28,
-        'css' => '.menu-icon-info-sm',
-      ),
-      'logout-sm' => array(
-        'x' => 28,
-        'y' => 28,
-        'css' => '.menu-icon-logout-sm',
-      ),
-      'new-sm' => array(
-        'x' => 28,
-        'y' => 28,
-        'css' => '.menu-icon-new-sm',
-      ),
-      'settings-sm' => array(
-        'x' => 28,
-        'y' => 28,
-        'css' => '.menu-icon-settings-sm',
-      ),
-      'power' => array(
-        'x' => 28,
-        'y' => 28,
-        'css' => '.menu-icon-power',
-      ),
-      'app' => array(
-        'x' => 24,
-        'y' => 24,
-        'css' => '.menu-icon-app',
-      ),
-      'app_blue' => array(
-        'x' => 24,
-        'y' => 24,
-        'css' => '.menu-icon-app-blue',
-      ),
       'logo' => array(
         'x' => 96,
         'y' => 26,

src/applications/help/application/PhabricatorHelpApplication.php

@@ -40,7 +40,7 @@ final class PhabricatorHelpApplication extends PhabricatorApplication {
       $item = id(new PHUIListItemView())
         ->setName($help_name)
         ->addClass('core-menu-item')
-        ->setIcon('info-sm')
+        ->setIcon('fa-info-circle')
         ->setAural($help_name)
         ->setOrder(200)
         ->setHref($application->getHelpURI());

src/applications/home/application/PhabricatorHomeApplication.php

@@ -62,7 +62,7 @@ final class PhabricatorHomeApplication extends PhabricatorApplication {
 
       $item = id(new PHUIListItemView())
         ->setName(pht('Create New...'))
-        ->setIcon('new-sm')
+        ->setIcon('fa-plus')
         ->addClass('core-menu-item')
         ->setHref('/home/create/')
         ->addSigil('quick-create-menu')

src/applications/settings/application/PhabricatorSettingsApplication.php

@@ -50,7 +50,7 @@ final class PhabricatorSettingsApplication extends PhabricatorApplication {
       $selected = ($controller instanceof PhabricatorSettingsMainController);
       $item = id(new PHUIListItemView())
         ->setName(pht('Settings'))
-        ->setIcon('settings-sm')
+        ->setIcon('fa-cogs')
         ->addClass('core-menu-item')
         ->setSelected($selected)
         ->setHref('/settings/')

src/view/page/menu/PhabricatorMainMenuView.php

@@ -144,14 +144,15 @@ final class PhabricatorMainMenuView extends AphrontView {
         'meta'  => array(
           'map' => array(
             $header_id => 'phabricator-application-menu-expanded',
-            $button_id => 'menu-icon-app-blue',
+            $button_id => 'sky',
           ),
         ),
       ),
       phutil_tag(
         'span',
         array(
-          'class' => 'phabricator-menu-button-icon sprite-menu menu-icon-app',
+          'class' => 'phabricator-menu-button-icon phui-icon-view '.
+                     'phui-font-fa fa-bars white',
           'id' => $button_id,
         ),
         ''));
@@ -188,10 +189,6 @@ final class PhabricatorMainMenuView extends AphrontView {
           ->setType(PHUIListItemView::TYPE_LABEL)
           ->setName(pht('Actions')));
       foreach ($actions as $action) {
-        $icon = $action->getIcon();
-        if ($icon) {
-          $action->appendChild($this->renderMenuIcon($icon));
-        }
         $view->addMenuItem($action);
       }
     }
@@ -210,14 +207,15 @@ final class PhabricatorMainMenuView extends AphrontView {
         'meta'  => array(
           'map' => array(
             $header_id => 'phabricator-search-menu-expanded',
-            $button_id => 'menu-icon-search-blue',
+            $button_id => 'sky',
           ),
         ),
       ),
       phutil_tag(
       'span',
       array(
-        'class' => 'phabricator-menu-button-icon sprite-menu menu-icon-search',
+        'class' => 'phabricator-menu-button-icon phui-icon-view '.
+                   'phui-font-fa fa-search white',
         'id' => $button_id,
       ),
       ''));
@@ -472,14 +470,4 @@ final class PhabricatorMainMenuView extends AphrontView {
     );
   }
 
-  private function renderMenuIcon($name) {
-    return phutil_tag(
-      'span',
-      array(
-        'class' => 'phabricator-core-menu-icon '.
-                   'sprite-menu menu-icon-'.$name,
-      ),
-      '');
-  }
-
 }