Fix some small notification / token issues
Summary: Fixes T3218. - Currently, Paste pages don't clear notifications about the paste (notably, token notifications). - Currently, Paste pages don't show tooltips on tokens. - `buildApplicationPage()` stopped respecting `pageObjects` (which controls whether "this page has been updated" is shown). Restore that. - Make `pageObjects` imply "clear notifications on this stuff". Test Plan: Viewed a tokened Paste. Verified it cleared the notification and hovering over a token showed a tip. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T3218 Differential Revision: https://secure.phabricator.com/D5971
This commit is contained in:
@@ -398,9 +398,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
|
||||
$page_pane->appendChild($comment_form->render());
|
||||
}
|
||||
|
||||
PhabricatorFeedStoryNotification::updateObjectNotificationViews(
|
||||
$user, $revision->getPHID());
|
||||
|
||||
$object_id = 'D'.$revision->getID();
|
||||
|
||||
$top_anchor = id(new PhabricatorAnchorView())
|
||||
@@ -445,6 +442,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
|
||||
$content,
|
||||
array(
|
||||
'title' => $object_id.' '.$revision->getTitle(),
|
||||
'pageObjects' => array($revision->getPHID()),
|
||||
));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user