archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix tokenizer placeholder issue

Browse Source 
Summary:
The placeholder property remains null despite it is set to a custom
value.

Test Plan:
Use a custom placeholder in `AphrontFormTokenizerControl`

```
id(new AphrontFormTokenizerControl())
  ->setPlaceholder('My custom placeholder...')
  ->setDatasource('/typeahead/common/projects/');
```

The placeholder should be set to "My custom placeholder..."

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4297
This commit is contained in:
Mailson Menezes
2012-12-29 17:57:51 -03:00
committed by epriestley
parent dbae9452f9
commit 250fe7fb77
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/view/form/control/AphrontFormTokenizerControl.php
View File

@@ -41,9 +41,8 @@ final class AphrontFormTokenizerControl extends AphrontFormControl {
$id = celerity_generate_unique_node_id(); $id = celerity_generate_unique_node_id();
} }
$placeholder = null;
if (!$this->placeholder) { if (!$this->placeholder) {
$placeholder = $this->getDefaultPlaceholder(); $this->placeholder = $this->getDefaultPlaceholder();
} }
$template = new AphrontTokenizerTemplateView(); $template = new AphrontTokenizerTemplateView();
@@ -64,7 +63,7 @@ final class AphrontFormTokenizerControl extends AphrontFormControl {
'limit' => $this->limit, 'limit' => $this->limit,
'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'), 'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
'username' => $username, 'username' => $username,
'placeholder' => $placeholder, 'placeholder' => $this->placeholder,
)); ));
} }