archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox

Browse Source 
Summary: Fixes T12533.

Test Plan: {F4853371}

Reviewers: chad, lvital

Reviewed By: lvital

Maniphest Tasks: T12533

Differential Revision: https://secure.phabricator.com/D17652
This commit is contained in:
epriestley
2017-04-10 17:09:22 -07:00
parent 5cf53f7b3b
commit 26d6096e0a
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
View File

@@ -124,10 +124,14 @@ abstract class DifferentialRevisionActionTransaction
list($options, $value) = $this->getActionOptions($viewer, $revision); list($options, $value) = $this->getActionOptions($viewer, $revision);
// Show the options if the user can select on behalf of two or more // Show the options if the user can select on behalf of two or more
// reviewers, or can force-accept on behalf of one or more reviewers. // reviewers, or can force-accept on behalf of one or more reviewers,
// or can accept on behalf of a reviewer other than themselves (see
// T12533).
$can_multi = (count($options) > 1); $can_multi = (count($options) > 1);
$can_force = (count($value) < count($options)); $can_force = (count($value) < count($options));
if ($can_multi || $can_force) { $not_self = (head_key($options) != $viewer->getPHID());
if ($can_multi || $can_force || $not_self) {
$field->setOptions($options); $field->setOptions($options);
$field->setValue($value); $field->setValue($value);
} }