Conpherence - make widget selector be a fun JS-based menu

Summary: Ref T3155. Also re-adds the ability to update Conpherence titles by letting user click the title and fill out a little dialogue. Also fixes a bunch of random bugs and what have you. I tried to make the javascript less mysterious by trying to code what's actually happening more explicitly. Still a work in progress all over the place but a good stopping point for feedback.

Test Plan: played around with Conpherence. In particular, went to /conpherence/ and re-sized and went to /conpherence/X/ and re-sized. Also loaded up my no conpherneces user.

Reviewers: epriestley

Reviewed By: epriestley

CC: chad, aran, Korvin

Maniphest Tasks: T3155

Differential Revision: https://secure.phabricator.com/D6022
This commit is contained in:
Bob Trahan
2013-05-24 10:50:18 -07:00
parent 6dda35897a
commit 27ad838939
20 changed files with 331 additions and 327 deletions

View File

@@ -25,7 +25,15 @@ abstract class ConpherenceController extends PhabricatorController {
->setName(pht('New Message'))
->setHref($this->getApplicationURI('new/'))
->setIcon('create')
->setWorkflow(true));
->setWorkflow(true))
->addAction(
id(new PhabricatorMenuItemView())
->setName(pht('Thread'))
->setHref('#')
->setIcon('action-menu')
->setStyle('display: none;')
->addClass('device-widgets-selector')
->addSigil('device-widgets-selector'));
return $crumbs;
}
@@ -38,7 +46,9 @@ abstract class ConpherenceController extends PhabricatorController {
}
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
->setName($title));
->setName($title)
->setHref($this->getApplicationURI('update/'.$conpherence->getID().'/'))
->setWorkflow(true));
return $crumbs;
}