Build a page for viewing all inline comments

Summary: Adds a very basic list of all inline comments, threaded, and their status. Kept this a little simpler than the mock, mostly because sorting here feels a little strange given threads would be all over the place. Not sure sorted is needed in practice anyways. I'd probably lean towards just adding a JS checkbox to hide certain rows if needed in the future.

Test Plan:
Test various commenting structures:

 - Leave Comment
 - Update Diff
 - Leave new comment
 - Reply to comment
 - Reply to comment as revision author
 - Mark items as done
 - Update diff again

{F4996915}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D18112
This commit is contained in:
Chad Little
2017-06-12 11:24:17 -07:00
parent 4b15871ced
commit 283a95d2aa
10 changed files with 292 additions and 65 deletions

View File

@@ -574,6 +574,12 @@ final class DifferentialRevisionViewController extends DifferentialController {
->setDisabled(!$can_edit)
->setWorkflow(!$can_edit));
$curtain->addAction(
id(new PhabricatorActionView())
->setIcon('fa-indent')
->setHref("/differential/revision/inlines/{$revision_id}/")
->setName(pht('List Inline Comments')));
$curtain->addAction(
id(new PhabricatorActionView())
->setIcon('fa-upload')