Moved Version Footer from Footer to /config/all
Summary: Fixed T2349 Test Plan: Could not visibly see version at footer any more. Appeared in the top of /config. Does not appear as a config option in /config. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2349 Differential Revision: https://secure.phabricator.com/D4539
This commit is contained in:
committed by
epriestley
parent
3a93ecdc53
commit
2888d58034
@@ -58,11 +58,27 @@ final class PhabricatorConfigAllController
|
||||
$panel->appendChild($table);
|
||||
$panel->setNoBackground();
|
||||
|
||||
$phabricator_root = dirname(phutil_get_library_root('phabricator'));
|
||||
$future = id(new ExecFuture('git log --format=%%H -n 1 --'))
|
||||
->setCWD($phabricator_root);
|
||||
list($err, $stdout) = $future->resolve();
|
||||
if (!$err) {
|
||||
$display_version = trim($stdout);
|
||||
} else {
|
||||
$display_version = pht('Unknown');
|
||||
}
|
||||
$version_property_list = id(new PhabricatorPropertyListView());
|
||||
$version_property_list->addProperty('Version', $display_version);
|
||||
|
||||
|
||||
$nav = $this->buildSideNavView();
|
||||
$nav->selectFilter('all/');
|
||||
$nav->setCrumbs($crumbs);
|
||||
$nav->appendChild($version_property_list);
|
||||
$nav->appendChild($panel);
|
||||
|
||||
|
||||
|
||||
return $this->buildApplicationPage(
|
||||
$nav,
|
||||
array(
|
||||
|
||||
Reference in New Issue
Block a user