archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Deploy new ArcanistManyWordsAboutDifferentialConstants class from D1328 into

Browse Source 
Phabricator

Summary: ...this breaks without D1328.   Used good ole "codemod" to do this
work, with lots of manual edits around 80 chars.

Test Plan: clicked around phabricator tool suite, particular differential, a
bunch

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1351
This commit is contained in:
Bob Trahan
2012-01-10 11:39:11 -08:00
parent a4ceba9101
commit 2a29a51080
47 changed files with 175 additions and 228 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/applications/differential/query/revision/DifferentialRevisionQuery.php
View File

@@ -135,8 +135,9 @@ final class DifferentialRevisionQuery {
* Calling this function will clear anything set by previous calls to
* @{method:withCommitHashes}.
*
* @param array List of pairs <Class DifferentialRevisionHash::HASH_$type
* constant, hash>
* @param array List of pairs <Class
* ArcanistDifferentialRevisionHash::HASH_$type constant,
* hash>
* @return this
* @task config
*/
@@ -381,9 +382,9 @@ final class DifferentialRevisionQuery {
$responsible_phid = reset($this->responsibles);
$open_statuses = array(
DifferentialRevisionStatus::NEEDS_REVIEW,
DifferentialRevisionStatus::NEEDS_REVISION,
DifferentialRevisionStatus::ACCEPTED,
ArcanistDifferentialRevisionStatus::NEEDS_REVIEW,
ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
ArcanistDifferentialRevisionStatus::ACCEPTED,
);
return queryfx_all(
@@ -461,7 +462,7 @@ final class DifferentialRevisionQuery {
$joins[] = qsprintf(
$conn_r,
'JOIN %T hash_rel ON hash_rel.revisionID = r.id',
DifferentialRevisionHash::TABLE_NAME);
ArcanistDifferentialRevisionHash::TABLE_NAME);
}
if ($this->ccs) {
@@ -587,9 +588,9 @@ final class DifferentialRevisionQuery {
$conn_r,
'status IN (%Ld)',
array(
DifferentialRevisionStatus::NEEDS_REVIEW,
DifferentialRevisionStatus::NEEDS_REVISION,
DifferentialRevisionStatus::ACCEPTED,
ArcanistDifferentialRevisionStatus::NEEDS_REVIEW,
ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
ArcanistDifferentialRevisionStatus::ACCEPTED,
));
break;
default: