archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Hide auxiliary fields that have no value set

Browse Source 
Reviewers: epriestly
This commit is contained in:
David Cramer
2011-12-16 16:31:02 -08:00
parent c3e1ab0751
commit 2a80bdd448
3 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/conduit/method/differential/getcommitmessage/ConduitAPI_differential_getcommitmessage_Method.php
View File

@@ -107,7 +107,7 @@ class ConduitAPI_differential_getcommitmessage_Method extends ConduitAPIMethod {
foreach ($aux_fields as $field_key => $field) { foreach ($aux_fields as $field_key => $field) {
$value = $field->renderValueForCommitMessage($is_edit); $value = $field->renderValueForCommitMessage($is_edit);
$label = $field->renderLabelForCommitMessage(); $label = $field->renderLabelForCommitMessage();
if ($value === null || !strlen($value)) { if (!strlen($value)) {
if ($field_key === 'title') { if ($field_key === 'title') {
$commit_message[] = '<<Enter Revision Title>>'; $commit_message[] = '<<Enter Revision Title>>';
} else { } else {

2
src/applications/differential/view/revisiondetail/DifferentialRevisionDetailView.php
View File

@@ -53,7 +53,7 @@ final class DifferentialRevisionDetailView extends AphrontView {
$rows = array(); $rows = array();
foreach ($this->auxiliaryFields as $field) { foreach ($this->auxiliaryFields as $field) {
$value = $field->renderValueForRevisionView(); $value = $field->renderValueForRevisionView();
if ($value !== null) { if (strlen($value)) {
$label = $field->renderLabelForRevisionView(); $label = $field->renderLabelForRevisionView();
$rows[] = $rows[] =
'<tr>'. '<tr>'.

6
src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php
View File

@@ -147,7 +147,11 @@ class ManiphestTaskDetailController extends ManiphestController {
$aux_field->setValue($attribute->getValue()); $aux_field->setValue($attribute->getValue());
} }
$dict[$aux_field->getLabel()] = $aux_field->renderForDetailView(); $value = $aux_field->renderForDetailView();
if (strlen($value)) {
$dict[$aux_field->getLabel()] = $value;
}
} }
} }