archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix a bug with T1643

Browse Source 
Summary: The construct `count(x == 0)` should be `count(x) == 0`. This causes a concrete problem because `count(0)` is 1.

Test Plan: eyeballed it~

Reviewers: btrahan, vrana, klimek

Reviewed By: klimek

CC: aran

Maniphest Tasks: T1643

Differential Revision: https://secure.phabricator.com/D4060
This commit is contained in:
epriestley
2012-11-30 12:09:37 -08:00
parent b37b725f4f
commit 2b69353519
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php
View File

@@ -73,8 +73,8 @@ abstract class PhabricatorMailReplyHandler {
* since this code is running and everything. * since this code is running and everything.
*/ */
private function shouldSendErrorEmail(PhabricatorMetaMTAReceivedMail $mail) { private function shouldSendErrorEmail(PhabricatorMetaMTAReceivedMail $mail) {
return count($mail->getToAddresses() == 1) && return (count($mail->getToAddresses()) == 1) &&
count($mail->getCCAddresses() == 0); (count($mail->getCCAddresses()) == 0);
} }
private function sendErrorEmail($error, private function sendErrorEmail($error,