Fix a bad %d for PHID
Summary: D1174 caught this issue -- we mean to load all //your// rules, but actually load //all// rules. Use %s correctly. Test Plan: Hit /herald/rule/ without an exception. Reviewers: fmoo, btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, btrahan Differential Revision: 1203
This commit is contained in:
@@ -376,7 +376,7 @@ class HeraldRuleController extends HeraldController {
|
||||
}
|
||||
|
||||
$all_rules = id(new HeraldRule())->loadAllWhere(
|
||||
'authorPHID = %d AND contentType = %s',
|
||||
'authorPHID = %s AND contentType = %s',
|
||||
$rule->getAuthorPHID(),
|
||||
$rule->getContentType());
|
||||
$all_rules = mpull($all_rules, 'getName', 'getID');
|
||||
|
||||
Reference in New Issue
Block a user