archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Don't attempt to discover parents commits for untracked branchs.

Browse Source 
Summary: Fixes T5195. Currently, the `./bin/repository parents` workflow doesn't respect tracked branches and will attempt to build parents caches for all branches.

Test Plan: For at least one of our repositories, this patch fixes the `Unknown commit` exception. Unfortunately, it doesn't seem to completely solve this problem though, but I suspect that this is due to commits that were overwritten with a `git push --force` or similar.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5195

Differential Revision: https://secure.phabricator.com/D9322
This commit is contained in:
Joshua Spence
2014-05-29 12:02:37 -07:00
committed by epriestley
parent 3929309225
commit 2f668493a0
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php
View File

@@ -58,6 +58,10 @@ final class PhabricatorRepositoryManagementParentsWorkflow
$graph = array(); $graph = array();
foreach ($refs as $ref) { foreach ($refs as $ref) {
if (!$repo->shouldTrackBranch($ref->getRefName())) {
continue;
}
$console->writeOut( $console->writeOut(
"%s\n", "%s\n",
pht('Rebuilding branch "%s"...', $ref->getRefName())); pht('Rebuilding branch "%s"...', $ref->getRefName()));