differential - lazy man's attempt at updated design
Summary: basically made the header elements for the individual panes and cleaned up the panes to make it look okay. tried to copy colors from @chad 's mocks. Test Plan: looks good to me Reviewers: epriestley, chad Reviewed By: chad CC: aran, Korvin Maniphest Tasks: T2004 Differential Revision: https://secure.phabricator.com/D4174
This commit is contained in:
@@ -185,35 +185,42 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
|
||||
1, // line number
|
||||
$this->repository->getCallsign());
|
||||
if ($editor_link) {
|
||||
$editor_link = phutil_render_tag(
|
||||
'a',
|
||||
array(
|
||||
'href' => $editor_link,
|
||||
'class' => 'button differential-toc-edit-all',
|
||||
),
|
||||
'Open All in Editor');
|
||||
$editor_link =
|
||||
phutil_render_tag(
|
||||
'a',
|
||||
array(
|
||||
'href' => $editor_link,
|
||||
'class' => 'button differential-toc-edit-all',
|
||||
),
|
||||
'Open All in Editor');
|
||||
}
|
||||
}
|
||||
|
||||
$reveal_link = javelin_render_tag(
|
||||
'a',
|
||||
array(
|
||||
'sigil' => 'differential-reveal-all',
|
||||
'mustcapture' => true,
|
||||
'class' => 'button differential-toc-reveal-all',
|
||||
),
|
||||
'Show All Context'
|
||||
);
|
||||
$reveal_link =
|
||||
javelin_render_tag(
|
||||
'a',
|
||||
array(
|
||||
'sigil' => 'differential-reveal-all',
|
||||
'mustcapture' => true,
|
||||
'class' => 'button differential-toc-reveal-all',
|
||||
),
|
||||
'Show All Context'
|
||||
);
|
||||
|
||||
$buttons =
|
||||
'<tr><td colspan="7">'.
|
||||
$editor_link.$reveal_link.
|
||||
'</td></tr>';
|
||||
|
||||
return
|
||||
id(new PhabricatorAnchorView())
|
||||
->setAnchorName('toc')
|
||||
->setNavigationMarker(true)
|
||||
->render().
|
||||
id(new PhabricatorHeaderView())
|
||||
->setHeader(pht('Table of Contents'))
|
||||
->render().
|
||||
'<div class="differential-toc differential-panel">'.
|
||||
$editor_link.
|
||||
$reveal_link.
|
||||
'<h1>Table of Contents</h1>'.
|
||||
'<table>'.
|
||||
'<tr>'.
|
||||
'<th></th>'.
|
||||
@@ -224,6 +231,7 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
|
||||
'<th class="differential-toc-mcov">Coverage (Touched)</th>'.
|
||||
'</tr>'.
|
||||
implode("\n", $rows).
|
||||
$buttons.
|
||||
'</table>'.
|
||||
'</div>';
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user