Reduce reliance on getRevisionID() on DifferentialComment
Summary: Ref T2222. A few rendering interfaces rely on fishing the revision ID out of a DifferentialComment, but it will only have the PHID soon. Pass in the revision and use it to determine the ID instead. Test Plan: Browsed, previewed, examined comments. Clicked anchors. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8209
This commit is contained in:
@@ -266,6 +266,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
|
||||
$comment_view->setUser($user);
|
||||
$comment_view->setTargetDiff($target);
|
||||
$comment_view->setVersusDiffID($diff_vs);
|
||||
$comment_view->setRevision($revision);
|
||||
|
||||
if ($arc_project) {
|
||||
Javelin::initBehavior(
|
||||
|
||||
Reference in New Issue
Block a user