Convert all calls to 'IconFont' to just 'Icon'

Summary: Mostly for consistency, we're not using other forms of icons and this makes all classes that use an icon call it in the same way.

Test Plan: tested uiexamples, lots of other random pages.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15125

src/applications/config/controller/PhabricatorConfigDatabaseController.php

@@ -36,7 +36,7 @@ abstract class PhabricatorConfigDatabaseController
     }
 
     return id(new PHUIIconView())
-      ->setIconFont($icon);
+      ->setIcon($icon);
   }
 
   protected function renderAttr($attr, $issue) {
@@ -71,9 +71,7 @@ abstract class PhabricatorConfigDatabaseController
       ->addActionLink(
         id(new PHUIButtonView())
           ->setTag('a')
-          ->setIcon(
-            id(new PHUIIconView())
-              ->setIconFont('fa-book'))
+          ->setIcon('fa-book')
           ->setHref($doc_link)
           ->setText(pht('Learn More')));
   }