Convert all calls to 'IconFont' to just 'Icon'

Summary: Mostly for consistency, we're not using other forms of icons and this makes all classes that use an icon call it in the same way.

Test Plan: tested uiexamples, lots of other random pages.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15125

src/applications/phame/controller/PhameHomeController.php

@@ -60,7 +60,7 @@ final class PhameHomeController extends PhamePostController {
       ->setTag('a')
       ->setText(pht('Actions'))
       ->setHref('#')
-      ->setIconFont('fa-bars')
+      ->setIcon('fa-bars')
       ->addClass('phui-mobile-menu')
       ->setDropdownMenu($actions);
 

src/applications/phame/controller/blog/PhameBlogViewController.php

@@ -48,7 +48,7 @@ final class PhameBlogViewController extends PhameLiveController {
         ->setTag('a')
         ->setText(pht('Actions'))
         ->setHref('#')
-        ->setIconFont('fa-bars')
+        ->setIcon('fa-bars')
         ->addClass('phui-mobile-menu')
         ->setDropdownMenu($actions);
 

src/applications/phame/controller/post/PhamePostViewController.php

@@ -29,7 +29,7 @@ final class PhamePostViewController
         ->setTag('a')
         ->setText(pht('Actions'))
         ->setHref('#')
-        ->setIconFont('fa-bars')
+        ->setIcon('fa-bars')
         ->addClass('phui-mobile-menu')
         ->setDropdownMenu($actions);
 

src/applications/phame/view/PhameBlogListView.php

@@ -45,7 +45,7 @@ final class PhameBlogListView extends AphrontTagView {
         $blog->getName());
 
       $icon = id(new PHUIIconView())
-        ->setIconFont('fa-plus-square')
+        ->setIcon('fa-plus-square')
         ->addClass('phame-blog-list-icon');
 
       $add_new = phutil_tag(

src/applications/phame/view/PhameDraftListView.php

@@ -53,7 +53,7 @@ final class PhameDraftListView extends AphrontTagView {
         $post->getTitle());
 
       $icon = id(new PHUIIconView())
-        ->setIconFont('fa-pencil-square-o')
+        ->setIcon('fa-pencil-square-o')
         ->addClass('phame-blog-list-icon');
 
       $edit = phutil_tag(

src/applications/phame/view/PhameNextPostView.php

@@ -30,7 +30,7 @@ final class PhameNextPostView extends AphrontTagView {
     require_celerity_resource('phame-css');
 
     $p_icon = id(new PHUIIconView())
-      ->setIconFont('fa-angle-left');
+      ->setIcon('fa-angle-left');
 
     $previous_icon = phutil_tag(
       'div',
@@ -69,7 +69,7 @@ final class PhameNextPostView extends AphrontTagView {
     }
 
     $n_icon = id(new PHUIIconView())
-      ->setIconFont('fa-angle-right');
+      ->setIcon('fa-angle-right');
 
     $next_icon = phutil_tag(
       'div',