Convert all calls to 'IconFont' to just 'Icon'

Summary: Mostly for consistency, we're not using other forms of icons and this makes all classes that use an icon call it in the same way.

Test Plan: tested uiexamples, lots of other random pages.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15125

src/applications/project/controller/PhabricatorProjectBoardViewController.php

@@ -405,7 +405,7 @@ final class PhabricatorProjectBoardViewController
     $sort_key) {
 
     $sort_icon = id(new PHUIIconView())
-      ->setIconFont('fa-sort-amount-asc bluegrey');
+      ->setIcon('fa-sort-amount-asc bluegrey');
 
     $named = array(
       PhabricatorProjectColumn::ORDER_NATURAL => pht('Natural'),
@@ -675,7 +675,7 @@ final class PhabricatorProjectBoardViewController
     }
 
     $column_button = id(new PHUIIconView())
-      ->setIconFont('fa-caret-down')
+      ->setIcon('fa-caret-down')
       ->setHref('#')
       ->addSigil('boards-dropdown-menu')
       ->setMetadata(

src/applications/project/controller/PhabricatorProjectMilestonesController.php

@@ -50,7 +50,7 @@ final class PhabricatorProjectMilestonesController
         id(new PHUIButtonView())
           ->setTag('a')
           ->setHref("/project/edit/?milestone={$id}")
-          ->setIconFont('fa-plus')
+          ->setIcon('fa-plus')
           ->setDisabled(!$can_create)
           ->setWorkflow(!$can_create)
           ->setText($button_text));

src/applications/project/controller/PhabricatorProjectProfileController.php

@@ -166,7 +166,7 @@ final class PhabricatorProjectProfileController
     }
 
     $watch_icon = id(new PHUIIconView())
-      ->setIconFont($watch_icon);
+      ->setIcon($watch_icon);
 
     return id(new PHUIButtonView())
       ->setTag('a')

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

@@ -50,7 +50,7 @@ final class PhabricatorProjectSubprojectsController
         id(new PHUIButtonView())
           ->setTag('a')
           ->setHref("/project/edit/?parent={$id}")
-          ->setIconFont('fa-plus')
+          ->setIcon('fa-plus')
           ->setDisabled(!$can_create)
           ->setWorkflow(!$can_create)
           ->setText($button_text));

src/applications/project/query/PhabricatorProjectSearchEngine.php

@@ -137,7 +137,7 @@ final class PhabricatorProjectSearchEngine
 
       $options[$icon->getKey()] = array(
         id(new PHUIIconView())
-          ->setIconFont($icon->getIcon()),
+          ->setIcon($icon->getIcon()),
         ' ',
         $icon->getLabel(),
       );

src/applications/project/view/PhabricatorProjectListView.php

@@ -29,7 +29,7 @@ final class PhabricatorProjectListView extends AphrontView {
       $color = $project->getColor();
 
       $icon_icon = id(new PHUIIconView())
-        ->setIconFont("{$icon} {$color}");
+        ->setIcon("{$icon} {$color}");
 
       $icon_name = $project->getDisplayIconName();
 

src/applications/project/view/PhabricatorProjectUserListView.php

@@ -86,7 +86,7 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
         ->setImageURI($handle->getImageURI());
 
       $icon = id(new PHUIIconView())
-        ->setIconFont($handle->getIcon().' lightbluetext');
+        ->setIcon($handle->getIcon().' lightbluetext');
 
       $subtitle = $handle->getSubtitle();
 
@@ -126,7 +126,7 @@ abstract class PhabricatorProjectUserListView extends AphrontView {
           ->setTag('a')
           ->setIcon(
             id(new PHUIIconView())
-              ->setIconFont('fa-list-ul'))
+              ->setIcon('fa-list-ul'))
           ->setText(pht('View All'))
           ->setHref("/project/members/{$id}/"));
     }