archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Convert all calls to 'IconFont' to just 'Icon'

Browse Source 
Summary: Mostly for consistency, we're not using other forms of icons and this makes all classes that use an icon call it in the same way.

Test Plan: tested uiexamples, lots of other random pages.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15125
This commit is contained in:
Chad Little
2016-01-27 20:38:01 -08:00
parent 43b8581d72
commit 36158dbdc0
130 changed files with 212 additions and 306 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/applications/uiexample/examples/PHUIButtonBarExample.php
View File

@@ -23,21 +23,17 @@ final class PHUIButtonBarExample extends PhabricatorUIExample {
);
$button_bar1 = new PHUIButtonBarView();
foreach ($icons as $text => $icon) {
$image = id(new PHUIIconView())
->setIconFont($icon);
$button = id(new PHUIButtonView())
->setTag('a')
->setColor(PHUIButtonView::GREY)
->setTitle($text)
->setIcon($image);
->setIcon($icon);
$button_bar1->addButton($button);
}
$button_bar2 = new PHUIButtonBarView();
foreach ($icons as $text => $icon) {
$image = id(new PHUIIconView())
->setIconFont($icon);
$button = id(new PHUIButtonView())
->setTag('a')
->setColor(PHUIButtonView::SIMPLE)
@@ -49,14 +45,12 @@ final class PHUIButtonBarExample extends PhabricatorUIExample {
$button_bar3 = new PHUIButtonBarView();
foreach ($icons as $text => $icon) {
$image = id(new PHUIIconView())
->setIconFont($icon);
$button = id(new PHUIButtonView())
->setTag('a')
->setColor(PHUIButtonView::SIMPLE)
->setTitle($text)
->setTooltip($text)
->setIcon($image);
->setIcon($icon);
$button_bar3->addButton($button);
}
@@ -64,13 +58,11 @@ final class PHUIButtonBarExample extends PhabricatorUIExample {
$button_bar4 = new PHUIButtonBarView();
$button_bar4->setBorderless(true);
foreach ($icons as $text => $icon) {
$image = id(new PHUIIconView())
->setIconFont($icon);
$button = id(new PHUIButtonView())
->setTag('a')
->setTitle($text)
->setTooltip($text)
->setIcon($image);
->setIcon($icon);
$button_bar4->addButton($button);
}