Remove obsolete code from ManiphestTaskQuery

Summary:
Ref T603. Cleans up some obsolete stuff here:

  - We no longer ever query by min/max priority (instead, `withPriorities(...)`).
  - A parent class provides limit/offset.
  - Result count is no longer reliable with policies. We could do "about X tasks" or something, but just drop it for now. There's only one remaining callsite anyway.

Test Plan:
  - `grep`
  - Viewed task list.
  - Viewed a project page.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7121
This commit is contained in:
epriestley
2013-09-25 13:44:36 -07:00
parent 3a87a95e11
commit 36343600c5
2 changed files with 3 additions and 81 deletions

View File

@@ -158,10 +158,8 @@ final class PhabricatorProjectProfileController
->withAnyProjects(array($project->getPHID()))
->withStatus(ManiphestTaskQuery::STATUS_OPEN)
->setOrderBy(ManiphestTaskQuery::ORDER_PRIORITY)
->setLimit(10)
->setCalculateRows(true);
->setLimit(10);
$tasks = $query->execute();
$count = $query->getRowCount();
$phids = mpull($tasks, 'getOwnerPHID');
$phids = array_merge(
@@ -175,8 +173,6 @@ final class PhabricatorProjectProfileController
$task_list->setTasks($tasks);
$task_list->setHandles($handles);
$open = number_format($count);
$content = hsprintf(
'<div class="phabricator-profile-info-group profile-wrap-responsive">
<h1 class="phabricator-profile-info-header">%s</h1>'.
@@ -184,7 +180,7 @@ final class PhabricatorProjectProfileController
'%s'.
'</div>
</div>',
pht('Open Tasks (%s)', $open),
pht('Open Tasks'),
$task_list);
return $content;