Use property tabs in Files
Summary: See screenshots. Some simplifications: - Tabbed and non-tabbed lists are now allowed to be mixed. We just make the non-tabbed lists permanent and put them on the bottom (e.g., image and audio data in Files). - You can provide a tab name instead of an entire tab object and we'll build an object for you. - We respect `setSelected()` on the tab objects now. Test Plan: See screenshots. Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran Differential Revision: https://secure.phabricator.com/D7362
This commit is contained in:
@@ -725,22 +725,6 @@ final class PhabricatorFile extends PhabricatorFileDAO
|
||||
return $this;
|
||||
}
|
||||
|
||||
public static function getMetadataName($metadata) {
|
||||
switch ($metadata) {
|
||||
case self::METADATA_IMAGE_WIDTH:
|
||||
$name = pht('Width');
|
||||
break;
|
||||
case self::METADATA_IMAGE_HEIGHT:
|
||||
$name = pht('Height');
|
||||
break;
|
||||
default:
|
||||
$name = ucfirst($metadata);
|
||||
break;
|
||||
}
|
||||
|
||||
return $name;
|
||||
}
|
||||
|
||||
|
||||
/**
|
||||
* Load (or build) the {@class:PhabricatorFile} objects for builtin file
|
||||
|
||||
Reference in New Issue
Block a user