archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix local-clobbering iterators in phabricator/

Browse Source 
Summary:
These are the issues identified by the linter in D2052. I don't think any cause bugs, but they are all reasonable errors to raise and the linter correctly
detected that they are suspicious.

Test Plan: Mostly inspection.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2053
This commit is contained in:
epriestley
2012-03-29 13:24:06 -07:00
parent b6e0ca5ac6
commit 36ab0c3313
5 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/view/control/table/AphrontTableView.php
View File

@@ -103,13 +103,13 @@ final class AphrontTableView extends AphrontView {
public function render() {
require_celerity_resource('aphront-table-view-css');
$class = $this->className;
if ($class !== null) {
$class = ' class="aphront-table-view '.$class.'"';
$table_class = $this->className;
if ($table_class !== null) {
$table_class = ' class="aphront-table-view '.$table_class.'"';
} else {
$class = ' class="aphront-table-view"';
$table_class = ' class="aphront-table-view"';
}
$table = array('<table'.$class.'>');
$table = array('<table'.$table_class.'>');
$col_classes = array();
foreach ($this->columnClasses as $key => $class) {