archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Fix access to undeclared variable when trying to create invalid Auth provider

Browse Source 
Summary: Ref T6971. This fixes the error the user reported. Not sure what's up with the root cause of their issue.

Test Plan: Went to `/auth/config/new/asdfqwer/` and got a 404 instead of an exception.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T6971

Differential Revision: https://secure.phabricator.com/D11388
This commit is contained in:
epriestley
2015-01-14 06:55:18 -08:00
parent 2ff85620f0
commit 39406bd1f3
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/applications/auth/controller/config/PhabricatorAuthEditController.php
View File

@@ -31,6 +31,8 @@ final class PhabricatorAuthEditController
$is_new = false; $is_new = false;
} else { } else {
$provider = null;
$providers = PhabricatorAuthProvider::getAllBaseProviders(); $providers = PhabricatorAuthProvider::getAllBaseProviders();
foreach ($providers as $candidate_provider) { foreach ($providers as $candidate_provider) {
if (get_class($candidate_provider) === $provider_class) { if (get_class($candidate_provider) === $provider_class) {