Fix an issue where certain configurations could fail to publish revision feed stories
Summary: See PHI292. This is just a generalization of D18851: feed stories have the same issue as mail. Don't hide "requested a review" in either mail or feed.
Test Plan:
- Enable prototypes.
- No harbormaster builds.
- Create a revision.
- Pre-patch: no feed story.
- Post-patch: feed story.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18886
This commit is contained in:
@@ -100,6 +100,13 @@ final class DifferentialTransaction
|
||||
return true;
|
||||
}
|
||||
break;
|
||||
case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
|
||||
// Don't hide the initial "X requested review: ..." transaction from
|
||||
// mail or feed even when it occurs during creation. We need this
|
||||
// transaction to survive so we'll generate mail and feed stories when
|
||||
// revisions immediately leave the draft state. See T13035 for
|
||||
// discussion.
|
||||
return false;
|
||||
}
|
||||
|
||||
return parent::shouldHide();
|
||||
@@ -111,12 +118,6 @@ final class DifferentialTransaction
|
||||
// Don't hide the initial "X added reviewers: ..." transaction during
|
||||
// object creation from mail. See T12118 and PHI54.
|
||||
return false;
|
||||
case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
|
||||
// Don't hide the initial "X requested review: ..." transaction from
|
||||
// mail even when it occurs during creation. We need this transaction
|
||||
// to survive so we'll generate mail when revisions immediately leave
|
||||
// the draft state. See T13035 for discussion.
|
||||
return false;
|
||||
}
|
||||
|
||||
return parent::shouldHideForMail($xactions);
|
||||
|
||||
Reference in New Issue
Block a user