archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Project revamp part 2: Edit

Browse Source 
Summary:
Taking a pass at revamping the edit pages in Projects. Specifically:

 - Remove EditMainController
 - Move actions from EditMain to Profile
 - Move properties from EditMain to Profile
 - Move timeline from EditMain to Profile
 - Move Open Tasks from Profile to sidenavicon
 - Add custom icons and colors to timeline

Feel free to bang on this a bit and give feedback, feels generally correct to me.

Test Plan: Edit everything I could on various projects. Check links, timelines, actions.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11421
This commit is contained in:
Chad Little
2015-01-19 10:14:27 -08:00
parent 9a7ad972cd
commit 3bc54c2041
12 changed files with 128 additions and 266 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/applications/project/controller/PhabricatorProjectEditDetailsController.php
View File

@@ -149,13 +149,8 @@ final class PhabricatorProjectEditDetailsController
));
}
if ($is_new) {
$redirect_uri =
$this->getApplicationURI('profile/'.$project->getID().'/');
} else {
$redirect_uri =
$this->getApplicationURI('edit/'.$project->getID().'/');
}
$redirect_uri =
$this->getApplicationURI('profile/'.$project->getID().'/');
return id(new AphrontRedirectResponse())->setURI($redirect_uri);
} catch (PhabricatorApplicationTransactionValidationException $ex) {
@@ -304,7 +299,7 @@ final class PhabricatorProjectEditDetailsController
if (!$is_new) {
$nav = $this->buildIconNavView($project);
$nav->selectFilter("edit/{$id}/");
$nav->selectFilter("details/{$id}/");
$nav->appendChild($form_box);
} else {
$nav = array($form_box);