In Drydock log views, respect newlines
Summary: Depends on D19070. Ref T13073. Some messages contain an interesting story or a clever anecdote. Respect newlines during rendering to preserve authorial intent.
Test Plan:
Viewed a message with linebreaks and could still read it.
{F5427754}
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T13073
Differential Revision: https://secure.phabricator.com/D19071
This commit is contained in:
@@ -53,6 +53,7 @@ final class DrydockLogListView extends AphrontView {
|
||||
$type = $type_object->getLogTypeName();
|
||||
$icon = $type_object->getLogTypeIcon($log_data);
|
||||
$data = $type_object->renderLog($log_data);
|
||||
$data = phutil_escape_html_newlines($data);
|
||||
} else {
|
||||
$type = pht('<Unknown: %s>', $type_key);
|
||||
$data = null;
|
||||
|
||||
Reference in New Issue
Block a user