Replace home directory list with a dashboard
Summary: Rough cut that still needs a lot of polish, but replace the directory list with more of a dashboard type thing: - Show "Unbreak Now", triage-in-your-projects, and other stuff that you're supposed to deal with, then feed. - Move tools a click a way behind nav -- this also lets us put more stuff there and subtools, etc., later. - Remove tabs. - Merge the category/item editing views. - I also added a light blue wash to the side nav, not sure if I like that or not. Test Plan: - Viewed all elements in empty and nonempty states. - Viewed applications, edited items/categories. Reviewers: btrahan, aran Reviewed By: btrahan CC: aran, epriestley, davidreuss Maniphest Tasks: T21, T631 Differential Revision: https://secure.phabricator.com/D1574
This commit is contained in:
@@ -369,26 +369,9 @@ class DifferentialRevisionListController extends DifferentialController {
|
||||
$views = array();
|
||||
switch ($filter) {
|
||||
case 'active':
|
||||
$active = array();
|
||||
$waiting = array();
|
||||
|
||||
// Bucket revisions into $active (revisions you need to do something
|
||||
// about) and $waiting (revisions you're waiting on someone else to do
|
||||
// something about).
|
||||
foreach ($revisions as $revision) {
|
||||
$status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW;
|
||||
$needs_review = ($revision->getStatus() == $status_review);
|
||||
$filter_is_author = ($revision->getAuthorPHID() == $user_phid);
|
||||
|
||||
// If exactly one of "needs review" and "the user is the author" is
|
||||
// true, the user needs to act on it. Otherwise, they're waiting on
|
||||
// it.
|
||||
if ($needs_review ^ $filter_is_author) {
|
||||
$active[] = $revision;
|
||||
} else {
|
||||
$waiting[] = $revision;
|
||||
}
|
||||
}
|
||||
list($active, $waiting) = DifferentialRevisionQuery::splitResponsible(
|
||||
$revisions,
|
||||
$user_phid);
|
||||
|
||||
$view = id(new DifferentialRevisionListView())
|
||||
->setRevisions($active)
|
||||
|
||||
@@ -6,8 +6,6 @@
|
||||
|
||||
|
||||
|
||||
phutil_require_module('arcanist', 'differential/constants/revisionstatus');
|
||||
|
||||
phutil_require_module('phabricator', 'aphront/response/redirect');
|
||||
phutil_require_module('phabricator', 'applications/differential/controller/base');
|
||||
phutil_require_module('phabricator', 'applications/differential/query/revision');
|
||||
|
||||
Reference in New Issue
Block a user