archive/phabricator
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Differential - allow setting viewPolicy from web ui during diff creation process

Browse Source 
Summary: Fixes T6152, T6237. This introduces a viewPolicy column to the DifferentialDiff, and re-jiggers the DifferentialDiff policy implementation such that things behave as before once associated with a revision, else use the DifferentialDiff policy column value.

Test Plan: made a diff with a non-standard view policy and noted that policy was still selected in the revision step. arc lint.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6237, T6152

Differential Revision: https://secure.phabricator.com/D10875
This commit is contained in:
Bob Trahan
2014-11-19 12:16:07 -08:00
parent 7ef236c9a6
commit 4350858628
19 changed files with 108 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
resources/sql/autopatches/20141119.differential.diff.policy.sql Normal file
View File

@@ -0,0 +1,5 @@
ALTER TABLE {$NAMESPACE}_differential.differential_diff
ADD viewPolicy VARBINARY(64) NOT NULL;
UPDATE {$NAMESPACE}_differential.differential_diff
SET viewPolicy = 'users' WHERE viewPolicy = '';