Update form styles, implement in many places
Summary: This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things: - Font Styles are correctly applied for form elements now. - Everything lines up! - Selects are larger, easier to read, interact. - Inputs have been squared. - Consistant CSS applied glow (try it!) - Improved Mobile Responsiveness - CSS applied to all form elements, not just Aphront - Many other minor tweaks. I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try. Test Plan: Tested many applications, forms, mobile and tablet. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5860
This commit is contained in:
@@ -355,6 +355,7 @@ final class ManiphestTaskEditController extends ManiphestController {
|
||||
$project_tokenizer_id = celerity_generate_unique_node_id();
|
||||
|
||||
$form = new AphrontFormView();
|
||||
$form->setFlexible(true);
|
||||
$form
|
||||
->setUser($user)
|
||||
->setAction($request->getRequestURI()->getPath())
|
||||
@@ -499,11 +500,6 @@ final class ManiphestTaskEditController extends ManiphestController {
|
||||
->addCancelButton($cancel_uri)
|
||||
->setValue($button_name));
|
||||
|
||||
$panel = new AphrontPanelView();
|
||||
$panel->setWidth(AphrontPanelView::WIDTH_FULL);
|
||||
$panel->setHeader($header_name);
|
||||
$panel->appendChild($form);
|
||||
$panel->setNoBackground();
|
||||
$inst1 = pht('Description Preview');
|
||||
$inst2 = pht('Loading preview...');
|
||||
|
||||
@@ -550,7 +546,7 @@ final class ManiphestTaskEditController extends ManiphestController {
|
||||
array(
|
||||
$crumbs,
|
||||
$error_view,
|
||||
$panel,
|
||||
$form,
|
||||
$description_preview_panel,
|
||||
),
|
||||
array(
|
||||
|
||||
Reference in New Issue
Block a user